I presume the context is the United States where a typical loan requires no more than a 20% down payment, providing 4:1 non-recourse leverage, with 3-4% interest. Outside of home mortgages, that sort of sweet-heart financing is only available to the very wealthy. When you factor in retained equity, at the end of the day, unless mobility or liquidity is exceptionally important to you, buying absolutely makes sense for the vast majority of Americans who can afford it. The home mortgage interest tax deduction is just icing on the cake.

That housing prices don't appreciate as much as the stock market is not dispositive. Now, once you already own a home, then of course the fact that the stock market provides higher returns matters for subsequent investment decisions. The calculus of residential ownership isn't nearly as favorable for non-owner-occupants. For small-time real estate investors banks offer you less leverage (3:1 or worse), higher interest rates, and your risk exposure is greater because you're purely speculating--whereas with owner-occupier you were presumably going to be living in that market, so you're only marginally speculating.

The situation is different in many other parts of the world with different socioeconomic policies (e.g. expensive mortgages, high down payments) and real estate markets (e.g. more common for housing to depreciate in value), but that's irrelevant to the U.S. You can't say whether owning makes sense or not without accounting for all the opportunity costs, which can vary widely. But in the U.S., generally and historically, buying a home adds up. Maybe the U.S. is worse off for incentivizing homeownership, but it is what it is.